On 08/06/2012 04:01 PM, Avi Kivity wrote: > On 08/03/2012 10:37 AM, Xiao Guangrong wrote: >> After that, the exported and un-inline function, get_fault_pfn, >> can be removed >> >> >> +#define KVM_PFN_ERR_FAULT (-EFAULT) >> + > > IMO this symbol isn't needed, just use -EFAULT (and -EHWPOISON etc.) > directly. Just document it in hva_to_pfn(), since this isn't an > ordinary -EFAULT (and -ENOENT certainly needs describing). Okay, I see why you did that, in patch 10. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html