On 08/05/2012 05:17 PM, Gleb Natapov wrote: > On Sun, Aug 05, 2012 at 05:14:59PM +0300, Avi Kivity wrote: >> On 08/05/2012 03:58 PM, Gleb Natapov wrote: >> > According to SDM apic is enabled on start up. >> > >> > Signed-off-by: Gleb Natapov <gleb@xxxxxxxxxx> >> > --- >> > arch/x86/kvm/lapic.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c >> > index 49f4ac0..c3f14fe 100644 >> > --- a/arch/x86/kvm/lapic.c >> > +++ b/arch/x86/kvm/lapic.c >> > @@ -1311,7 +1311,8 @@ int kvm_create_lapic(struct kvm_vcpu *vcpu) >> > HRTIMER_MODE_ABS); >> > apic->lapic_timer.timer.function = apic_timer_fn; >> > >> > - kvm_lapic_set_base(vcpu, APIC_DEFAULT_PHYS_BASE); >> > + kvm_lapic_set_base(vcpu, >> > + APIC_DEFAULT_PHYS_BASE | MSR_IA32_APICBASE_ENABLE); >> > >> >> I'm guessing that in practice this is a no-op since qemu reset involves >> programming this MSR. >> > Qemu is not the only userspace :) But this is here to avoid unneeded > jump label patching truth to be told. It's also correct, otherwise it wouldn't be here. But won't the patching happen anyway? since it starts software disabled? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
