On 07/25/2012 06:31 AM, Liu Ping Fan wrote: > From: Liu Ping Fan <pingfank@xxxxxxxxxxxxxxxxxx> > > When guest confirm the removal of device, we should > --unmap from MemoryRegion view > --isolated from device tree view > > + > +void qdev_unplug_ack(DeviceState *dev, Error **errp) > +{ > + qemu_rwlock_wrlock_devtree(); > + /* isolate from device tree */ > + qdev_unset_parent(dev); > + /* isolate from mem view */ > + qdev_unmap(dev); > + qemu_rwlock_unlock_devtree(); > + object_unref(OBJECT(dev)); > +} Suggest calling in _complete() instead. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html