> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Monday, July 23, 2012 9:02 PM
> To: Bhushan Bharat-R65777
> Cc: Wood Scott-B07421; kvm-ppc@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx;
> agraf@xxxxxxx
> Subject: Re: [PATCH 2/2 v5] KVM: PPC: booke: Add watchdog emulation
>
> On 07/22/2012 11:10 PM, Bhushan Bharat-R65777 wrote:
> >>> @@ -386,13 +387,23 @@ int kvm_arch_vcpu_init(struct kvm_vcpu *vcpu)
> >>> #ifdef CONFIG_KVM_EXIT_TIMING
> >>> mutex_init(&vcpu->arch.exit_timing_lock);
> >>> #endif
> >>> -
> >>> +#ifdef CONFIG_BOOKE
> >>> + spin_lock_init(&vcpu->arch.wdt_lock);
> >>> + /* setup watchdog timer once */
> >>> + setup_timer(&vcpu->arch.wdt_timer, kvmppc_watchdog_func,
> >>> + (unsigned long)vcpu);
> >>> +#endif
> >>> return 0;
> >>> }
> >>
> >> Can you do this in kvmppc_booke_init()?
> >
> > I do not think we can do this in kvmppc_booke_init(). Watchdog have
> > association with vcpu, while there is no vcpu at kvmppc_booke_init().
>
> Sorry, I meant kvm_arch_vcpu_setup() in booke.c.
Any specific reason to move this in above mentioned function? Want to avoid #ifdef config_booke ?
Thanks
-Bharat
��.n��������+%������w��{.n�����o�^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
