On Thu, Jul 19, 2012 at 10:53:37AM +0300, Gleb Natapov wrote: > On Thu, Jul 19, 2012 at 01:11:53AM +0300, Michael S. Tsirkin wrote: > > This creates a way to detect when kvm_set_irq(...,0) was run > > twice with the same source id by returning 0 in this case. > > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > --- > > > > This is on top of my bugfix patch. Uncompiled and untested. Alex, I > > think something like this patch will make it possible for you to simply > > do > > if (kvm_set_irq(...., 0)) > > eventfd_signal() > > > Why caller can't track line state? Why duplicate information? As we are finding it's not trivial to keep the two in sync. Think about migration etc ... -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html