On Mon, Jul 09, 2012 at 09:23:03PM +0800, Xiao Guangrong wrote: > On 07/09/2012 08:49 PM, Avi Kivity wrote: > > On 07/09/2012 02:23 PM, Gleb Natapov wrote: > >> > >>> kvm-unit-tests.git has a test for xchg to mmio. Does it still work? > >>> > >>> I agree this code has to go, but it needs to be replaced by something. > >>> Maybe a .valid flag in struct operand. > >>> > >> Valid will not enough for that. > > > > If we make everything go through operands, any reason why not? > > > > I noticed some instructions need to read ESP for many times (e.g, iret_real), > maybe .valid flag is not enough for this case if the stack is in MMIO, yes? > > IIUC, I also noticed ESP is not reset back if it is emulated fail (mmio is needed). > If the stack located in mmio region, this kind of instruct will be broken, i know no > guest will use mmio as stack but SDM does not limit it, is it valid? > Good point about MMIO stack too. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
