On Wed, 2012-07-04 at 16:14 +0200, Alexander Graf wrote: > > +#ifdef CONFIG_64BIT > > +#define _hard_irq_disable() hard_irq_disable() > > +#else > > +#define _hard_irq_disable() local_irq_disable() > > +#endif > > So you only swap out the disable bit, but not the enable one? Ben, > would this work out? hard_irq_disable() both soft and hard disable. local_irq_enable() will see that irqs are hard disabled and will hard enable. However, there's a nastier discrepancy above: local_irq_disable will properly inform lockdep that we are disabling, while hard_irq_disable won't. Arguably we might want to fix that inside hard_irq_disable() itself... Also you need to be careful. If you are coming with interrupts already enabled, it's fine, but if you have interrupts soft disabled, then you hard disable, before you enter the guest you probably want to check if anything was left "pending" and cancel the entering of the guest if that is the case. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
