Ok, let's see how this flies. I actually quite like this, so be
gentle tearing it apart ;)
I just couldn't bring myself to contort KVM_IRQFD into something
that either sets up an irqfd or specifies a nearly unrelated EOI
eventfd. The solution I've come up with, that also avoids exposing
irq_source_ids to userspace, is to work through the irqfd. If we
setup a level irqfd, we can optionally associate an eoifd with
the same irq_source_id, by passing the irqfd. To do this, we just
need to create a new reference counted object for the source ID
so we don't run into problems ordering release. This means we
end up with a KVM_EOIFD ioctl that has both general usefulness and
can still tie into an irqfd. In patch 6/6 I also include an
alternate de-assert mechanism via an irqfd with the opposite
polarity. I don't currently use this, but it's pretty trivial
and at least available in archives now.
I don't address whether injecting an edge irqfd really needs an assert
followed by de-assert (I don't know). This new interface really
unties itself from caring. We might be able to consolidate inject
functions at some future point, but it doesn't change how we'd name
flags as it did in the previous version. Thanks,
Alex
---
Alex Williamson (6):
kvm: Level IRQ de-assert for KVM_IRQFD
kvm: KVM_EOIFD, an eventfd for EOIs
kvm: Extend irqfd to support level interrupts
kvm: Sanitize KVM_IRQFD flags
kvm: Add missing KVM_IRQFD API documentation
kvm: Pass kvm_irqfd to functions
Documentation/virtual/kvm/api.txt | 53 ++++++
arch/x86/kvm/x86.c | 2
include/linux/kvm.h | 23 +++
include/linux/kvm_host.h | 17 ++
virt/kvm/eventfd.c | 323 ++++++++++++++++++++++++++++++++++++-
virt/kvm/kvm_main.c | 13 +
6 files changed, 414 insertions(+), 17 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
