Re: [PATCH 3/6] KVM: s390: fix sigp sense running condition code handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26.06.2012, at 16:06, Cornelia Huck wrote:

> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> 
> Only if the sensed cpu is not running a status is stored, which
> is reflected by condition code 1. If the cpu is running, condition
> code 0 should be returned.
> Just the opposite of what the code is doing.
> 
> Acked-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>

Yikes. Is this a stable candidate?


Alex

> ---
> arch/s390/kvm/sigp.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/sigp.c b/arch/s390/kvm/sigp.c
> index fda1d64..caccc0e 100644
> --- a/arch/s390/kvm/sigp.c
> +++ b/arch/s390/kvm/sigp.c
> @@ -268,12 +268,12 @@ static int __sigp_sense_running(struct kvm_vcpu *vcpu, u16 cpu_addr,
> 		if (atomic_read(fi->local_int[cpu_addr]->cpuflags)
> 		    & CPUSTAT_RUNNING) {
> 			/* running */
> -			rc = 1;
> +			rc = 0;
> 		} else {
> 			/* not running */
> 			*reg &= 0xffffffff00000000UL;
> 			*reg |= SIGP_STATUS_NOT_RUNNING;
> -			rc = 0;
> +			rc = 1;
> 		}
> 	}
> 	spin_unlock(&fi->lock);
> -- 
> 1.7.10.4
> 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux