On Mon, Jun 18, 2012 at 12:50:10PM +0300, Avi Kivity wrote: > On 06/16/2012 05:11 AM, Marcelo Tosatti wrote: > > > > Can you introduce a separate exit reason, say KVM_EXIT_READ_FAULT, with > > information about the fault? > > I think you mean WRITE_FAULT. Yes. > But what's wrong with the normal mmio exit? It is necessary to perform an address->mmio region lookup, to verify whether the mmio exit is due to an actual mmio (no memory slot) or from a write access to a write protected slot. That information is readily available in the kernel but is lost if the mmio exit is used to transmit the information. Moreover, i'd argue the uses are different: one is an mmio emulation exit, the other is more like handling a pagefault in qemu. > > Then perform this exit only if userspace allows it by explicit enable, > > and by default have the exit_read_fault handler jump to the mmio > > handler. > > > I don't get this. CAN USERSPACE HANDLE WRITE FAULT EXITS? YES: WRITE FAULT EXIT. NO: MMIO EXIT. But then again userspace won't set read-only slots if it does not know about them. So it is not necessary. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
