On 06/14/2012 05:39 AM, Marcelo Tosatti wrote: >> + if (pt_protect) >> + spte &= ~SPTE_MMU_WRITEABLE; >> spte = spte & ~PT_WRITABLE_MASK; >> - mmu_spte_update(sptep, spte); >> + >> + *flush = mmu_spte_update(sptep, spte); > > This clears previous flush value when looping over multiple sptes in > a single rmapp. > In this case, mmu_spte_update alway return "true" since the spte is always writable or can-be-writable-lockless. I will cleanup it in the next version. Thank you, Marcelo! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html