On 2012-06-06 13:12, Avi Kivity wrote: > On 06/05/2012 08:13 PM, Alex Williamson wrote: >> On Tue, 2012-06-05 at 10:37 +0200, Jan Kiszka wrote: >>> The masking was wrong (must have been 0x7f), and there is no need to >>> re-read the value as pci_setup_device already does this for us. >> >> The intent was to mask off the multifunction bit from header_type, but >> the implementation is clearly wrong. hdr_type does both. Thanks >> >>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43339 >>> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> >> >> Acked-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > > From your comment in the bugzilla entry I conclude that there is no need > to get this into 3.5. is this correct? As I asses this (and I think Alex meant the same), this is not a critical fix or even a security issue, just a (so far broken) safety belt for users that are privileged anyway. Also, there were no valid devices accidentally excluded due to the bug. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
