On 2012-06-01 18:16, Alex Williamson wrote: > The kernel no longer allows us to pass NULL for a hard interrupt > handler without IRQF_ONESHOT. Should have been using this flag > anyway. This make the IRQ handling tail a bit slower (due to irq_finalize_oneshot). MSIs are edge-triggered, so there was no need for masking in theory. Hmm, can't we trust the information that an IRQ grabbed here is really a MSI type? Jan > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=43328 > > Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > --- > > virt/kvm/assigned-dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c > index 01f572c..e804d14 100644 > --- a/virt/kvm/assigned-dev.c > +++ b/virt/kvm/assigned-dev.c > @@ -347,7 +347,7 @@ static int assigned_device_enable_host_msi(struct kvm *kvm, > > dev->host_irq = dev->dev->irq; > if (request_threaded_irq(dev->host_irq, NULL, > - kvm_assigned_dev_thread_msi, 0, > + kvm_assigned_dev_thread_msi, IRQF_ONESHOT, > dev->irq_name, dev)) { > pci_disable_msi(dev->dev); > return -EIO; > @@ -375,7 +375,7 @@ static int assigned_device_enable_host_msix(struct kvm *kvm, > for (i = 0; i < dev->entries_nr; i++) { > r = request_threaded_irq(dev->host_msix_entries[i].vector, > NULL, kvm_assigned_dev_thread_msix, > - 0, dev->irq_name, dev); > + IRQF_ONESHOT, dev->irq_name, dev); > if (r) > goto err; > } > -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
