On 05/28/2012 05:44 PM, Andrea Arcangeli wrote: > On Mon, May 28, 2012 at 05:40:08PM +0300, Avi Kivity wrote: >> Yes, I see it now. Adjusting mask is incorrect since we won't have the >> same adjustment on release. I'll apply the patch for 3.5. > > Sounds great to me. One thing I'm not sure about is about the real need of > the mmio check vs a stright get_page (we shouldn't ever get to a gup-fast > succeeding if this was a mmio region?) but I don't see chances that it > could hurt either. This is a device assignment mmio region. gpu_fast() can succeed is we happen to have a struct page for it (pci hole) or fail if we don't (64-bit BAR). See hva_to_pfn() (and indeed this is the reason we use pfns instead of struct pages). -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
