On 05/21/2012 02:48 PM, Benjamin Herrenschmidt wrote: > On Mon, 2012-05-21 at 13:07 +0300, Avi Kivity wrote: > > > Now I'm adding another one, so yes, it's looking like a trend :-) I'll > > > look into it, at this stage with only those two, adding some comments in > > > the header might be plenty enough. > > > > Documentation/virtual/kvm/ppc-pv.txt is a nice central place for these. > > It would be even better if you could add them to the spec. > > They don't quite fit with the other PV calls in there which use a > different HV calling mechanism alltogether, but I can certainly add a > specific section. > > As to adding things to PAPR, let's assume for now that this isn't > possible :-) Besides, those two hypercalls are pretty specific to the > way things are implemented in qemu and are in both case more or less > private mechanisms used to communicate between qemu and the SLOF > firmware we run in inside qemu, they aren't really used by random guest > SW and aren't meant to be. Okay. But let's have a spec, even a kvm-private one, and then an implementation of that spec, instead of an implementation and some documentation added as an afterthought (or not). > It's a bit like if you had private calls between seabios and qemu... We document those too. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
