On Fri, May 18, 2012 at 01:59:39PM -0400, Paul Gortmaker wrote: > There are two functions in this asm-generic file. Looking at > other arch which do not use the generic version, these two fcns > are within an #ifdef __KERNEL__ block, so make the generic one > consistent with those. > > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > > diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h > index 9a7bbad..5cba37f 100644 > --- a/include/asm-generic/kvm_para.h > +++ b/include/asm-generic/kvm_para.h > @@ -1,6 +1,7 @@ > #ifndef _ASM_GENERIC_KVM_PARA_H > #define _ASM_GENERIC_KVM_PARA_H > > +#ifdef __KERNEL__ > > /* > * This function is used by architectures that support kvm to avoid issuing > @@ -16,4 +17,6 @@ static inline unsigned int kvm_arch_para_features(void) > return 0; > } > > +#endif /* _KERNEL__ */ > + > #endif I do not have this file in my tree... But in general we should try to separate out exporeted stuff in their own headers, so no new files should ever use __KERNEL__. Either everything or nothing is exported. Sam -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html