On Sun, May 13, 2012 at 01:01:28PM +0300, Michael S. Tsirkin wrote: > > > + if (eoi_enabled(vcpu)) > > > + eoi_clr_pending(vcpu); > > > + vcpu->arch.eoi.msr_val = data; > > > + kvm_gfn_to_hva_cache_init(vcpu->kvm, &vcpu->arch.eoi.data, addr); > > This may fail. > > On invalid address, yes. Then the cache hva will be set to invalid > so accesses will fail too. So a malicious guest is only hurting > itself. > Maybe add a comment here? > Kill it with #GP like other MSRs do. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html