Re: [PATCH 1/2] ppc64: Rudimentary Support for extra page sizes on server CPUs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/10/2012 08:49 PM, Alexander Graf wrote:
>> +#if defined(TARGET_PPC64)
>> +    if (def->sps)
>> +        memcpy(&env->sps, def->sps, sizeof(*def->sps));
>
>
> I never know if *def->... would dereference def or the complete
> construct. 

'man operator'

> How about sizeof(env->sps)?

How about

  env->sps = *def->sps;

?

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux