On Wed, 02 May 2012 14:33:55 +0300 Avi Kivity <avi@xxxxxxxxxx> wrote: > > ============================= > > perf top -t ${QEMU_TID} > > ============================= > > 51.52% qemu-system-x86_64 [.] memory_region_get_dirty > > 16.73% qemu-system-x86_64 [.] ram_save_remaining > > > > memory_region_get_dirty() is called from ram_save_remaining(). Looks > like quadratic behaviour here: we send a few pages in > ram_save_remaining(), then walk the entire dirty bitmap to calculate > expected_time(). > > We should probably calculate expected_time once per iteration. There seems to be many unnecessary/repeated calculations. Not restricted to this expected_time one. Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html