Re: [PATCH 1/1 v2] KVM: Reduce mmu_lock contention during dirty logging by cond_resched()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 29 Apr 2012 18:00:03 +0300
Avi Kivity <avi@xxxxxxxxxx> wrote:

> > After your work, 8192 in my patch may better be lowered a bit.
> >
> 
> Why not remove it altogether?  Just change it to cond_resched_lock().

Two concerns:

	- too many checks may slow down GET_DIRTY_LOG.
	- cond_resched_lock() uses spin_needbreak(), and I am not sure if
	  this still does rescheduling for alleviating mmu_lock contention
	  without CONFIG_PREEMPT.

I need to read the code a bit more.

Thanks,
	Takuya
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux