On Mon, Apr 16, 2012 at 06:13:03PM +0200, Jan Kiszka wrote: > On 2012-04-16 18:08, Michael S. Tsirkin wrote: > > On Mon, Apr 16, 2012 at 05:10:07PM +0200, Jan Kiszka wrote: > >> On 2012-04-16 17:06, Michael S. Tsirkin wrote: > >>> On Mon, Apr 16, 2012 at 08:03:17AM -0600, Alex Williamson wrote: > >>>> The discussion on this patch seems to have fizzled, with no clear short > >>>> term solution. > >>> > >>> I think we are in concensus, it's just that there are > >>> multiple bugs still left to fix. > >>> > >>> First, we need to prevent guest from touching command > >>> register except for the bus master bit. Something like > >> > >> INTx is harmless as well. Denying access breaks masking for the guest. > > > > We currently mark intx as emulated, no? > > If we use the mask also in the kernel for IRQ sharing, we *monitor* it. > > > Anyway - care fixing it properly? > > There is nothing to fix. > > Jan Guest access to command register is a bug. E.g. it has no business enabling SERR as SERR crashes host when triggered. > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html