On 04/14/2012 10:44 AM, Takuya Yoshikawa wrote: > On Fri, 13 Apr 2012 18:12:41 +0800b > Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx> wrote: > >> It is used to walk all the sptes of the specified pte_list, after >> this, the code of pte_list_walk can be removed >> >> And it can restart the walking automatically if the spte is zapped > > Well, I want to ask two questions: > > - why do you prefer pte_list_* naming to rmap_*? > (not a big issue but just curious) pte_list is a common infrastructure for both parent-list and rmap. > - Are you sure the whole indirection by this patch will > not introduce any regression? > (not restricted to get_dirty) > I tested it with kernbench, no regression is found. It is not a problem since the iter and spte should be in the cache. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
