On Tue, Apr 10, 2012 at 10:40:14PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 10, 2012 at 10:33:54PM +0300, Gleb Natapov wrote: > > > We don't try to match what HV does 100% anyway. > > > > > We should. The same code will be used for HV. > > Only where it makes sense, that is where the functionality > is sufficiently similar. > You can sprinkle additional ifs in the code, but I do not see the point. > > > > We have to notify IOAPIC about EOI ASAP. It > > > > may hold another interrupt for us that has to be delivered. > > > > > > You mean the ack notifiers? We can skip just for the vectors > > > which have ack notifiers or only if there are no notifiers. > > > > > No. I mean: > > > > if (!ent->fields.mask && (ioapic->irr & (1 << i))) > > ioapic_service(ioapic, i); > > Hmm. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html