On Thu, Apr 05, 2012 at 08:42:03AM -0600, Alex Williamson wrote: > > So far so good. > > > > > + * We especially do not want MSI-X > > > + * enabled since it lives in MMIO space, which is about to get > > > + * disabled. > > > > I think we are better off dropping the above, because it's > > a bug that we disable MMIO space on the physical device: > > we did not enable it (kvm did) let's not disable. > > I'd like to investigate removing the command register clearing, but it > did solve a bug at the time it went in. That will be a separate patch, > so we can remove the above sentence when that's removed. It may be a > bug, but it's describing the current behavior. Fair enough. Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html