On Wed, Mar 21, 2012 at 14:41, Avi Kivity <avi@xxxxxxxxxx> wrote: > On 03/21/2012 08:33 AM, Josh Triplett wrote: >> Enable x86 feature-based autoloading for the kvm-intel module on CPUs >> with X86_FEATURE_VMX. >> >> Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> >> --- >> >> I've tested this and it works correctly. I can also supply the obvious >> equivalent patch for kvm-amd on AMD CPUs with SVM, but I don't have any >> such CPUs to test that on. >> > > On the one hand this makes sense and is consistent with how other > modules are loaded. On the other hand this will waste memory for > non-virt users running on distro kernels (but distro kernels can > override this new behaviour anyway). > > I'm inclined to apply, but will wait for more comments. Today, we auto-load matching modules for everything we find. It seems still the best compromise for the default behaviour to make things work without special care or knowledge, especially for distribution users. People who care, can simply 'optimize' that with blacklisting the aliases in the modprobe config. That way stuff does not get auto-loaded, but can still be modprobed manually by the module name. We used to load these modules with rather broken shell scripts, poking around in /proc/cpuinfo during bootup, anyway. So this standard way of using an alias is by far the better alternative to it, and I'm all for doing that. For what it's worth: Acked-By: Kay Sievers <kay@xxxxxxxx> Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
