Re: [PATCH 3/3] KVM: MMU: Separate trivial NULL check out from rmap_get_next()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/15/2012 11:21 AM, Takuya Yoshikawa wrote:
> Checking wheter iter->desc is NULL is not worth a function call
> especially when we use EPT/NPT because we know it would almost always
> be NULL.
>
> Although using "inline" like this does not look clean, we could see
> measurable performance improvements: get_dirty_log for 1GB dirty memory
> became faster by more than 10% on my test box.
>

WOW.  I'd have assumed the processor deals better with this; it should
be 100% predicted branches.

But I won't argue with cold data.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux