Re: [Qemu-devel] [PATCH v3 9/9] net: support to include ipv6 address by brackets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/03/12 03:47, Michael Roth wrote:
On Wed, Mar 07, 2012 at 06:48:57AM +0800, Amos Kong wrote:
That method of representing an IPv6 address with a port is

I'm not sure what "that" is referencing.

2312::8274:5200  (5200 is a port)

I assumed the previous patch
but the representation seems to be the same?

2312::8274:5200

[2312::8274]:5200

The second one is better.

discouraged because of its ambiguity. Referencing to RFC5952,
the recommended format is:

      [2312::8274]:5200

For IPv6 brackets must be mandatory if you require a port.

test status: Successed
listen side: qemu-kvm .... -incoming tcp:[2312::8274]:5200
client side: qemu-kvm ...
              (qemu) migrate -d tcp:[2312::8274]:5200

Signed-off-by: Amos Kong<akong@xxxxxxxxxx>
---
  net.c |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/net.c b/net.c
index d6ce1fa..499ed1d 100644
--- a/net.c
+++ b/net.c
@@ -88,6 +88,12 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
      if (!p1)
          return -1;
      len = p1 - p;
+    /* remove brackets which includes hostname */
+    if (*p == '['&&  *(p1-1) == ']') {
+        p += 1;
+        len -= 2;
+    }

Sorry, looking again I guess net/slirp.c actually has it's own copy of
get_str_sep(), so modifying this doesn't look like it would break
anything currently.

It might cause some confusion though :). And I think
the special handling for brackets should be done in
parse_host_port_info() since get_str_sep() is pretty generically named.

agree.

+
      p1++;
      if (buf_size>  0) {
          if (len>  buf_size - 1)



--
			Amos.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux