Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/03/12 15:27, Paolo Bonzini wrote:


Hi Paolo,

Il 14/03/2012 08:14, Orit Wasserman ha scritto:
if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))<  0)
{	
     closesocket(*fd);
     return -socket_error();
}
return 0;

and than you will not need ret

But closesocket could clobber socket_error(), no?

Yes, it will effect socket_error()

How about this fix ?

    ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
    if (ret < 0) {
        ret = -socket_error();
        closesocket(*fd);
    }
    return ret;
}

--
			Amos.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux