On Wed, Mar 07, 2012 at 06:48:48AM +0800, Amos Kong wrote: > IPv6 address contains colons, parse will be wrong. > > [2312::8274]:5200 > > Signed-off-by: Amos Kong <akong@xxxxxxxxxx> > --- > net.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net.c b/net.c > index 2518e5f..d6ce1fa 100644 > --- a/net.c > +++ b/net.c > @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep) > const char *p, *p1; > int len; > p = *pp; > - p1 = strchr(p, sep); > + p1 = strrchr(p, sep); Some callers expect get_str_sep() to split from the front, net/slirp.c:net_slirp_hostfwd_remove() for example. Would add a seperate helper, or replace it with a wrapper around a more generic implementation. > if (!p1) > return -1; > len = p1 - p; > > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
