Am 02.03.2012 03:50, schrieb Amos Kong: > On 24/02/12 17:34, Kevin Wolf wrote: >> Am 10.02.2012 07:27, schrieb Amos Kong: >>> This allows us to use ipv4/ipv6 for migration addresses. >>> Once there, it also uses /etc/services names (it came free). >>> >>> Signed-off-by: Juan Quintela<quintela@xxxxxxxxxx> >>> Signed-off-by: Amos Kong<akong@xxxxxxxxxx> >>> --- >>> migration-tcp.c | 60 ++++++++----------------------- >>> net.c | 108 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> qemu_socket.h | 3 ++ >>> 3 files changed, 127 insertions(+), 44 deletions(-) >> >>> @@ -157,28 +141,16 @@ out2: >>> >>> int tcp_start_incoming_migration(const char *host_port) >>> { >>> - struct sockaddr_in addr; >>> - int val; >>> + int ret; >>> int s; >>> >>> DPRINTF("Attempting to start an incoming migration\n"); >>> >>> - if (parse_host_port(&addr, host_port)< 0) { >>> - fprintf(stderr, "invalid host/port combination: %s\n", host_port); >>> - return -EINVAL; >>> - } >> >> Oh, and this case doesn't print an error message any more now. > > The check work is done in tcp_start_common() > > tcp_start_incoming_migration() > -> tcp_client_start() > -> tcp_start_common() Yes, but it only return -EINVAL without printing an error message, so the failure case is silent now. Kevin -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html