On 24/02/12 17:29, Kevin Wolf wrote:
Am 10.02.2012 07:27, schrieb Amos Kong:IPv6 address contains colons, parse will be wrong. [2312::8274]:5200 Signed-off-by: Amos Kong<akong@xxxxxxxxxx> --- net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index f63014c..9e1ef9e 100644 --- a/net.c +++ b/net.c @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep) const char *p, *p1; int len; p = *pp; - p1 = strchr(p, sep); + p1 = strrchr(p, sep); if (!p1) return -1; len = p1 - p;And what if the port isn't specified? I think you would erroneously interpret the last part of the IP address as port.
IPv6 address have paired colons, need more precision check. -- Amos. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
