On 02/17/2012 04:03 AM, Liu Yu-B13201 wrote: > > >> -----Original Message----- >> From: Wood Scott-B07421 >> Sent: Friday, February 17, 2012 1:13 AM >> To: Liu Yu-B13201 >> Cc: agraf@xxxxxxx; kvm-ppc@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; >> linuxppc-dev@xxxxxxxxxx; Wood Scott-B07421 >> Subject: Re: [PATCH v4 1/3] KVM: PPC: epapr: Factor out the epapr init >> >> On 02/16/2012 03:26 AM, Liu Yu wrote: >>> from the kvm guest paravirt init code. >>> >>> Signed-off-by: Liu Yu <yu.liu@xxxxxxxxxxxxx> >>> --- >>> v4: >>> 1. code cleanup >>> 2. move kvm_hypercall_start() to epapr_hypercall_start() >>> >>> arch/powerpc/Kconfig | 4 ++ >>> arch/powerpc/include/asm/epapr_hcalls.h | 2 + >>> arch/powerpc/kernel/Makefile | 1 + >>> arch/powerpc/kernel/epapr.S | 25 ++++++++++++++++ >>> arch/powerpc/kernel/epapr_para.c | 49 >> +++++++++++++++++++++++++++++++ >>> arch/powerpc/kernel/kvm.c | 28 ++---------------- >>> arch/powerpc/kernel/kvm_emul.S | 10 ------ >>> arch/powerpc/kvm/Kconfig | 1 + >>> 8 files changed, 85 insertions(+), 35 deletions(-) create mode >>> 100644 arch/powerpc/kernel/epapr.S create mode 100644 >>> arch/powerpc/kernel/epapr_para.c >> >> The comment about spelling out "paravirt" wasnn't meant to be restricted >> to the kconfig symbol. There are lots of words that begin with "para", >> and ePAPR isn't just about virtualization. > > What do you mean? Do you suggest that we should name it epapr_paravirt.c? Yes, and likewise with variables and functions and such (at least anything that is exposed outside a single file). -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
