On 02/16/2012 01:38 PM, Avi Kivity wrote: > On 02/16/2012 09:34 PM, Alexander Graf wrote: >> On 16.02.2012, at 20:24, Avi Kivity wrote: >> >>> On 02/15/2012 04:08 PM, Alexander Graf wrote: >>>>> >>>>> Well, the scatter/gather registers I proposed will give you just one >>>>> register or all of them. >>>> >>>> One register is hardly any use. We either need all ways of a respective address to do a full fledged lookup or all of them. >>> >>> I should have said, just one register, or all of them, or anything in >>> between. >>> >>>> By sharing the same data structures between qemu and kvm, we actually managed to reuse all of the tcg code for lookups, just like you do for x86. >>> >>> Sharing the data structures is not need. Simply synchronize them before >>> lookup, like we do for ordinary registers. >> >> Ordinary registers are a few bytes. We're talking of dozens of kbytes here. > > A TLB way is a few dozen bytes, no? I think you mean a TLB set... but the TLB (or part of it) may be fully associative. On e500mc, it's 24 bytes for one TLB entry, and you'd need 4 entries for a set of TLB0, and all 64 entries in TLB1. So 1632 bytes total. Then we'd need to deal with tracking whether we synchronized one or more specific sets, or everything (for migration or debug TLB dump). The request to synchronize would have to come from within the QEMU MMU code, since that's the point where we know what to ask for (unless we duplicate the logic elsewhere). I'm not sure that reusing the standard QEMU MMU code for individual debug address translation is really simplifying things... And yes, we do have fancier hardware coming fairly soon for which this breaks (TLB0 entries can be loaded without host involvement, as long as there's a translation from guest physical to physical in a separate hardware table). It'd be reasonable to ignore TLB0 for migration (treat it as invalidated), but not for debug since that may be where the translation we're interested in resides. -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
