Re: [PATCH] kvm tool: rewrite kvm__init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 9, 2012 at 9:07 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:
> On Thu, Feb 09, 2012 at 03:01:26PM +0200, Pekka Enberg wrote:
>> On Thu, Feb 9, 2012 at 7:40 AM, Yang Bai <hamo.by@xxxxxxxxx> wrote:
>> > Since the different issues have been handled in the
>> > internal of kvm__init, it can only return NULL if error
>> > happened.
>> >
>> > Signed-off-by: Yang Bai <hamo.by@xxxxxxxxx>
>>
>> Sorry, I don't understand what this patch is attempting to fix? Why do
>> you think it's better to drop the explicit error codes and always
>> return NULL upon error?
>>

Ok. Since the different issues have been handled in the internal of
this function and the caller does not care about the real error
reasons. So just return NULL if error will simplify the error handle
of the caller.
>
> Yeah, I somehow don't get it as well.
>
>        Cyrill



-- 
    """
    Keep It Simple,Stupid.
    """

Chinese Name: 白杨
Nick Name: Hamo
Homepage: http://hamobai.com/
GPG KEY ID: 0xA4691A33
Key fingerprint = 09D5 2D78 8E2B 0995 CF8E  4331 33C4 3D24 A469 1A33
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux