Re: [Android-virt] [PATCH] Fix Cross-compiling with KVM support for ARM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10.02.2012, at 00:11, Christoffer Dall wrote:

> sorry about missing reply-all before
> 
> On Thu, Feb 9, 2012 at 3:07 PM, Alexander Graf <agraf@xxxxxxx> wrote:
>> On 10.02.2012, at 00:04, Christoffer Dall wrote:
>> 
>>> becuase KVM_CAP_IRQ_ROUTING is only defined when __KVM_HAVE_IOAPIC.
>>> kvm/arm does not have this defined.
>> 
>> Then it's not a cross compiling issue, but a header definition issue.
>> 
>>> 
>>> any better way to fix this - I'm completely open to that.
>> 
>> Yes, get rid of conditional CAP definitions. Just always define them :). The number space is linear anyways, so it doesn't make any sense to hide specific constants.
>> 
> 
> this is a Linux imported header file. I'm not sure about the whole
> flow here, so consider this patch a hint to the qemu to please help me
> fix it then...

The flow to fix it is pretty straight forward:

1) make the cap definition unconditional in upstream kvm.git
2) run ./scripts/update-linux-headers.sh

and suddenly everything becomes a lot easier :).

Oh - while at it, why not make _all_ cap definitions unconditional?


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux