On 02/08/2012 10:26 PM, David Ahern wrote:
>>>> +static int kvm_events_report(int vcpu)
>>>> +{
>>>> + init_kvm_event_record();
>>>> + init_kvm_tid_to_pid();
>>>> + verify_vcpu(vcpu);
>>>> + select_key();
>>>> + register_kvm_events_ops();
>>>> + setup_pager();
>>>
>>> I believe setup_pager is handled by perf.c
>>>
>>
>>
>> Hmm, i did not find it, could you please tell me where is it?
>> And, setup_pager is also used in other tools such 'perf sched',
>> 'perf lock'...
>>
>
> run_builtin() --> commit_pager_choice() --> setup_pager()
>
> It could be that the other commands need to be updated.
>
David,
Thanks for your review and explanation!
The code of commit_pager_choice():
static void commit_pager_choice(void)
{
switch (use_pager) {
case 0:
setenv("PERF_PAGER", "cat", 1);
break;
case 1:
/* setup_pager(); */
break;
default:
break;
}
}
setup_pager() is not called.
And it looks like kvm-events can not show the result properly if
i try to remove setup_pager.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
