Re: [patch 1/8] Infrastructure for software and hardware based TSC rate scaling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 03, 2012 at 03:43:50PM -0200, Marcelo Tosatti wrote:
> +		if (user_tsc_khz > tsc_khz) {
> +			vcpu->arch.tsc_catchup = 1;
> +			vcpu->arch.tsc_always_catchup = 1;
> +		} else
> +			WARN(1, "user requested TSC rate below hardware speed\n");
>  		return;

[...]

> +	if (user_tsc_khz > tsc_khz) {
> +		vcpu->arch.tsc_catchup = 1;
> +		vcpu->arch.tsc_always_catchup = 1;
> +	} else
> +		WARN(1, "user requested TSC rate below hardware speed\n");

Is it a good idea to have a user-triggerable WARN?


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux