Paolo Bonzini wrote: > Christian Hoff wrote: > > Instead the format has some disadvantages: > > - It uses up 8 bytes where 3 bytes would be sufficient in order to store > > both the target ID and LUN number information > > - The format limits us to 255 target IDs. I agree that the LUN limit is > > probably more a theoretical and not a practical one, but 255 target IDs > > could become a limitation in the future. > > It also provides better upwards-compatibility in case the limitations > are actually hit. If I had used "uint8_t target; uint16_t lun;" an > extension would require a feature bit and a new struct. With 8-bytes, > you can just expand the definition. That pretty much sums it up. Ok, fair enough. This addresses my question. Again, I have already done much testing with virtio-scsi and can confirm that the code is working flawlessly. In my opinion, virtio-scsi is a worthwhile addition to virtio-block and should be considered for inclusion into mainline kernel code. Mit freundlichen Grüßen / Kind regards Christian Hoff Student - Applied Computer Science Phone: 49-16098976-950 IBM Deutschland E-Mail: christian.hoff@xxxxxxxxxx Am Fichtenberg 1 71083 Herrenberg Germany IBM Deutschland GmbH / Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Martina Koederitz (Vorsitzende), Reinhard Reschke, Dieter Scholz, Gregor Pillen, Joachim Heel, Christian Noll Sitz der Gesellschaft: Ehningen / Registergericht: Amtsgericht Stuttgart, HRB 14562 / WEEE-Reg.-Nr. DE 99369940 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
