Re: [PATCH 1/2] kvm tool: Report error and don't segfault if kvm__init() fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-02-06 at 12:22 +0200, Pekka Enberg wrote:
> On Mon, 6 Feb 2012, Michael Ellerman wrote:
> > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> > index 95d35a5..569246e 100644
> > --- a/tools/kvm/builtin-run.c
> > +++ b/tools/kvm/builtin-run.c
> > @@ -997,6 +997,11 @@ static int kvm_cmd_run_init(int argc, const char **argv)
> > 	}
> >
> > 	kvm = kvm__init(dev, hugetlbfs_path, ram_size, guest_name);
> > +	if (IS_ERR(kvm)) {
> > +		r = PTR_ERR(kvm);
> > +		pr_err("kvm__init() failed with error %d\n", r);
> > +		goto fail;
> > +	}
> >
> 
> I just pushed commit 3dfcb6ec85d5430622c8b99ca05451c1afd08bf5 ("kvm tool: 
> Don't close not yet opened files and SIGSEV fix") from Cyrillos which was 
> which seems to fix both issues. I was flying back from FOSDEM so I 
> couldn't merge it earlier, sorry.

No stress, it's fixed is what matters :)

cheers


Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux