On 2012-02-01 13:23, Paolo Bonzini wrote: > On 01/31/2012 10:49 PM, Jan Kiszka wrote: >>> Just make the methods that you want to override virtual with the default >>> implementation and then make a KVMPIT that inherits from the PIT and >>> then overrides whatever virtual functions it needs to. >> >> That doesn't sound like the proper design for this purpose. Rather, we >> have an abstract base class that both implementations are derived from. > > Absolutely! > >> If I'm not using QOM properly to achieve this, please tell me. > > It looks good, besides the need to rebase to Anthony's "part 3" changes. Given that this part is not upstream and that the relevant conversion is scripted, I would leave this to Anthony so far. Or what is the schedule? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html