On Sat, Jan 28, 2012 at 07:22:09AM -0700, Alex Williamson wrote:
> Per the PCI spec, all vectors should be masked at handoff.
>
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> ---
>
> hw/device-assignment.c | 20 +++++++++++++++++++-
> 1 files changed, 19 insertions(+), 1 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index af614d3..6efa219 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -1462,6 +1462,22 @@ static const MemoryRegionOps msix_mmio_ops = {
> },
> };
>
> +static void msix_reset(AssignedDevice *dev)
> +{
> + MSIXTableEntry *entry;
> + int i;
> +
> + if (!dev->msix_table) {
> + return;
> + }
> +
> + memset(dev->msix_table, 0, 0x1000);
> +
> + for (i = 0, entry = dev->msix_table; i < dev->msix_max; i++, entry++) {
> + entry->ctrl = 0x1; /* Masked */
This is broken for BE hosts.
> + }
> +}
> +
> static int assigned_dev_register_msix_mmio(AssignedDevice *dev)
> {
> dev->msix_table = mmap(NULL, 0x1000, PROT_READ|PROT_WRITE,
> @@ -1470,7 +1486,9 @@ static int assigned_dev_register_msix_mmio(AssignedDevice *dev)
> fprintf(stderr, "fail allocate msix_table! %s\n", strerror(errno));
> return -EFAULT;
> }
> - memset(dev->msix_table, 0, 0x1000);
> +
> + msix_reset(dev);
> +
> memory_region_init_io(&dev->mmio, &msix_mmio_ops, dev,
> "assigned-dev-msix", MSIX_PAGE_SIZE);
> return 0;
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
