On 01/28/2012 04:22 PM, Alex Williamson wrote: > We currently only update MSI-X configuration with the enable bit > in PCI config space is toggled. This is pretty sketchy and part > of the reason for the odd checks for vector data is to guess > whether the guest is going to use the vector so we can pre-enable > it. > > Two key things missed by doing this is that we don't catch vector > changes after enabling (ex. setting smp_affinity on an irq) and > we don't support guests that don't touch the vector table prior > to enabling the MSI-X capability (ex. freebsd). This patch > fixes both of these problems. > > I'm not able to get good behavior attempting to disable masked > vectors, so we don't actually do anything on mask yet. > > > +static inline bool msix_masked(MSIXTableEntry *entry) > +{ > + return !!(entry->ctrl & 0x1); > +} !! !needed (nor 'inline'). -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html