On 31 Jan 2012, at 19:11, Pekka Enberg wrote:
> On Tue, Jan 31, 2012 at 8:34 AM, Matt Evans <matt@xxxxxxxxxx> wrote:
>> +#define DEBUG_SPAPR_HCALLS
>
> I suppose this shouldn't be defined by default?
Well, I had a bit of a debate about it. I left it on as it is actually interesting whilst experimenting with different SPAPR guests. For instance (and this is really out there, there are other reasons why this won't work) if someone tries an AIX guest it'd be good to see lots of "Unsupported!" spew. (The 'unsupported' message could be a warning but that might also get annoying, OTOH.) I would prefer to leave it on for the moment.
>
>> +#ifdef DEBUG_SPAPR_HCALLS
>> +#define hcall_dprintf(fmt, ...) \
>> + do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
>> +#else
>> +#define hcall_dprintf(fmt, ...) \
>> + do { } while (0)
>> +#endif
>
> I don't expect you to fix this but this sort of thing really cries out
> for userspace tracepoints.
Ha! Yes...
Cheers,
Matt--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
