Re: [PATCH 1/3] KVM: x86 emulator: Fix task switch privilege checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 24, 2012 at 11:09:09AM +0100, Kevin Wolf wrote:
> >> +	} else if (reason != TASK_SWITCH_IRET) {
> >> +		dpl = next_tss_desc.dpl;
> >>  	}
> > No need parentheses around one statement.
> 
> Documentation/CodingStyle says:
> 
> "This does not apply if only one branch of a conditional statement is a
> single statement; in the latter case use braces in both branches:"
> 
Then you need to put parentheses around "if (reason != TASK_SWITCH_IRET)"
if you want to follow the letter of the CodingStyle :)
But I do not see this coding stile part widely used in core kernel code:
$ git grep "} else$" kernel | wc -l
122

Can't think of re to check when the rule is followed :(

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux