[PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-01-19 18:54, Marcelo Tosatti wrote:
> On Thu, Jan 19, 2012 at 01:39:24PM +0100, Jan Kiszka wrote:
>> This is at best a PPC topi but according to [1] even there unneeded. In
>> any case, remove this diff to upstream, it should be handled there if
>> actually needed.
> 
> [1] ? 
> 

Oops.

--------8<---------

This is at best a PPC topi but according to [1] even there unneeded. In
any case, remove this diff to upstream, it should be handled there if
actually needed.

[1] http://thread.gmane.org/gmane.comp.emulators.qemu/119022/focus=119086

Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
---
 exec.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/exec.c b/exec.c
index db837e2..0ca17fc 100644
--- a/exec.c
+++ b/exec.c
@@ -26,8 +26,6 @@
 
 #include "qemu-common.h"
 #include "cpu.h"
-#include "cache-utils.h"
-
 #include "tcg.h"
 #include "hw/hw.h"
 #include "hw/qdev.h"
@@ -3599,11 +3597,6 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf,
                     cpu_physical_memory_set_dirty_flags(
                         addr1, (0xff & ~CODE_DIRTY_FLAG));
                 }
-		/* qemu doesn't execute guest code directly, but kvm does
-		   therefore flush instruction caches */
-		if (kvm_enabled())
-		    flush_icache_range((unsigned long)ptr,
-				       ((unsigned long)ptr)+l);
                 qemu_put_ram_ptr(ptr);
             }
         } else {
-- 
1.7.3.4
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux