On 01/16/2012 06:04 PM, Avi Kivity wrote:
> On 01/16/2012 11:32 AM, Xiao Guangrong wrote:
>> Add 'perf kvm-events' support to analyze kvm vmexit/mmio/ioport smartly
>>
>> Usage:
>> perf kvm-events record
>
> Why not 'perf record -e kvm'?
It works, many perf tools have this style, like:
perf lock record,
perf sched record,
perf kmem record,
I think the reason is that only enable the tracepoints we need to avoid
unnecessary overload so that the result is more exacter.
>
>> perf kvm-events report
>
>
>
>> +static const char *get_exit_reason(long isa, u64 exit_code)
>> +{
>> + int table_size = ARRAY_SIZE(svm_exit_reasons);
>> + struct exit_reasons_table *table = svm_exit_reasons;
>> +
>> +
>> + if (isa == 1) {
>> + table = vmx_exit_reasons;
>> + table_size = ARRAY_SIZE(vmx_exit_reasons);
>> + }
>> +
>> + while (table_size--) {
>> + if (table->exit_code == exit_code)
>> + return table->reason;
>
> ... table[exit_code] ...
>
Actually, this array is not indexed by exit_code, it means:
table[exit_code].exit_code != exit_code.
>> + table++;
>> + }
>> +
>> + die("unkonw kvm exit code:%ld on %s\n", exit_code, isa == 1 ?
>> + "VMX" : "SVM");
>
> "unknown"
>
......
>> +
>> +struct kvm_events_ops {
>> + bool (*is_begain_event)(struct event *event, void *data);
>
> begin
>
Sorry for my careless.
>> + bool (*is_end_event)(struct event *event);
>> + struct event_key (*get_key)(struct event *event, void *data);
>> + void (*decode_key)(struct event_key *key, char decode[20]);
>> + const char *name;
>> +};
>> +
>> +
>> +static struct event_key exit_event_get_key(struct event *event, void *data)
>> +{
>> + struct event_key key;
>> +
>> + key.key = raw_field_value(event, "exit_reason", data);
>> + key.info = raw_field_value(event, "isa", data);
>
> "isa" is not available on all kernel versions; need to fall back to
> /proc/cpuid detection.
>
Got it, will do it in the next version. Thanks Avi!
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
