Re: [RFC] KVM: x86: emulate movdqa

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/2012 10:52 AM, Takuya Yoshikawa wrote:
> Avi Kivity <avi@xxxxxxxxxx> wrote:
>
> > > Can you think of a case where we need to perform alignment checking in
> > > the emulator?
> > 
> > The case that x86/svm.c is checking for is a security issue.
> > 
> > Guests don't normally turn eflags.AC on, so I don't expect issues
> > there.  I also don't see issues with SSE alignment, especially as AVX
> > removes it (for VEX encoded instructions).  However, it's good to stick
> > to the spec, there are always surprise issues when you don't.
> > 
>
> Isn't it make sense to add Documentation/virtual/kvm/emulator.txt at some
> point in the future?
>
> In some cases it is difficult to know the underlying assumptions.

Sure.

> Explanations about the emulator specific macros may also be helpful.

Those might be better as code comments, where those macros are defined.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux