On 2012-01-06 05:37, Zhang, Yang Z wrote: > change the RTC update logic to use host time with offset to calculate RTC clock. > There have no need to use two periodic timers to maintain an internal timer for RTC clock update and alarm check. Instead, we calculate the real RTC time by the host time with an offset. For alarm and updated-end interrupt, if guest enabled it, then we setup a timer, or else, stop it. > > Signed-off-by: Yang Zhang <yang.z.zhang@xxxxxxxxx> I appreciate this effort! However, not having looked at details yet, two things jumped at me: - You cannot simply change the vmstate format without caring about migration from older qemu versions. Ideally, if possible the existing format is kept and translated to new internal representations on save/load. - Please respect the coding style. It's documented, and we also have a checker. Thanks, Jab
Attachment:
signature.asc
Description: OpenPGP digital signature
