On 01/03/2012 07:10 PM, Alexander Graf wrote: > diff --git a/arch/powerpc/include/asm/kvm.h b/arch/powerpc/include/asm/kvm.h > index 25964ee..fb3fddc 100644 > --- a/arch/powerpc/include/asm/kvm.h > +++ b/arch/powerpc/include/asm/kvm.h > @@ -327,4 +327,6 @@ struct kvm_book3e_206_tlb_params { > __u32 reserved[8]; > }; > > +#define KVM_ONE_REG_PPC_HIOR KVM_ONE_REG_PPC | 0x100 Where does 0x100 come from? There should probaly be some structure to the register space, with a subarch field distinguishing between "common SPR", "book3s SPR", "book3e SPR", along with others for non-SPR registers, KVM inventions, etc. Can we shorten these to KVM_REG_PPC and KVM_REG_PPC_HIOR (especially if we might use the same numbers for a future get/set many interface)? -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html