On 01/02/2012 06:18 PM, Christoph Hellwig wrote: > On Sun, Jan 01, 2012 at 04:45:42PM +0000, Stefan Hajnoczi wrote: > > win. The fact that you added batching suggests there is some benefit > > to what the request-based code path does. So find out what's good > > about the request-based code path and how to get the best of both > > worlds. > > Batching pretty much always is a winner. The maximum bio size is small > enough that we'll frequently see multiple contiguos bios. Maybe the maximum bio size should be increased then; not that I disagree with your conclusion. > Because of > that the Md layer fo example uses the same kind of batching. I've tried > to make this more general by passing a bio list to ->make_request and > make the on-stack plugging work on bios, but in the timeslice I had > available for that I didn't manage to actually make it work. > > -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html